Skip to content

Parse selected rules and selected groups separately in Profile#37

Merged
skateman merged 1 commit intoOpenSCAP:masterfrom
marleystipich2:RHICOMPL-2833
Mar 30, 2022
Merged

Parse selected rules and selected groups separately in Profile#37
skateman merged 1 commit intoOpenSCAP:masterfrom
marleystipich2:RHICOMPL-2833

Conversation

@marleystipich2
Copy link
Copy Markdown
Collaborator

@marleystipich2 marleystipich2 commented Mar 24, 2022

No description provided.

@marleystipich2 marleystipich2 mentioned this pull request Mar 24, 2022
Merged
14 tasks
skateman
skateman reviewed Mar 25, 2022
View reviewed changes
Comment thread lib/openscap_parser/group.rb
skateman
skateman reviewed Mar 25, 2022
View reviewed changes
Comment thread lib/openscap_parser/profile.rb Outdated
@marleystipich2 marleystipich2 force-pushed the RHICOMPL-2833 branch 4 times, most recently from bf217ac to f043538 Compare March 28, 2022 22:17
marleystipich2
marleystipich2 commented Mar 28, 2022
View reviewed changes
Comment thread lib/openscap_parser/profile.rb Outdated
@marleystipich2 marleystipich2 force-pushed the RHICOMPL-2833 branch 2 times, most recently from fe8e2e0 to cd2ba4b Compare March 29, 2022 19:17
skateman
skateman requested changes Mar 30, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks and please put an empty line between tests.

Comment thread lib/openscap_parser/regex_handler.rb Outdated
Comment thread lib/openscap_parser/profile.rb Outdated
Comment thread test/openscap_parser/test_result_file_test.rb
@skateman
Copy link
Copy Markdown
Collaborator

skateman commented Mar 30, 2022

If you would also keep a selected_entity_ids with the original implementation, I think our semantical test coverage could be increased by testing if the two subsets are disjoint + equal to the superset without exception.

@marleystipich2 marleystipich2 force-pushed the RHICOMPL-2833 branch 2 times, most recently from 252910e to 5c89374 Compare March 30, 2022 15:10
@skateman skateman merged commit c919f6d into OpenSCAP:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skateman skateman skateman requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marleystipich2 @skateman